[W3] Lab2 - First Pull Request

This week we had to create a pull request for other student's work done last week. 

I found Paul's project interesting, since he made his CLI tool with bash script. 

I looked into Paul's project and found that Paul's CLI only supported the "-v" argument so I decided to make it support "--version" as well. I also wanted to add add one more optional feature, which will add a command line flag to allow specifying a custom User Agent when doing the curl request. 


First, I opened an issue as follow:



and forked Paul's repo to my GitHub Account. 

Then I cloned it to my local machine and made some changes. The changes are as follow:


I also added how to use my new function in the README file.

I pushed the changes to GitHub and the "Compare & pull request" appeared on the repo


Finally, I created a pull request for Paul!


Final Thoughts

It was really confusing at first, however, now I think I have a good enough understanding how git and gitHub works. I made some mistakes during this lab, for instance, I forgot to stage a file for the first push, so I had to create a new branch and made a pull request again. Thankfully, I think it went well at last!

Comments

Post a Comment

Popular posts from this blog

[W2] Release 0.1 - getting out of Tutorial Land

Image
This week we had to create a cli tool with our choice of language. I chose Python and started researching how to create a cli tool with it. Since I've never used Python (only watched several tutorial videos), it was frustrating at first. PyCharm couldn't recognize the import statements and configuring virtual environment for the project was totally confusing.  I started by searching the regEx which will collect all URLs starting with either "http://" or "https://". Then I put those links in a List and removed duplicates by using a Dictionary (since Dictionary cannot have duplicate keys, it removed the duplicates. I could have done with Set as well!) Then I made requests to the links and collected status_codes for the request. If the status code was 200, it would print the message "GOOD" with a color green. If the status code was 400, 404, or couldn't get the response within 1.5s, it would print the message "BAD" with the color red. Ot
Read more

About Me

  print("Hi! My name is Jongwon Jang")      I'm a 3rd year student studying at Seneca College located in North York, Toronto and thrilled to study open source development with wonderful developers all around the world. I'm passionate about web development, especially using libraries such as React and currently exploring new tools and techs for back-end development. Also, I am planning to learn python in depth until the course ends and hoping I'll be good at it.      I chose OSD600 over other courses, because I really wanted to know how programmers collaborate and learn how real life programming works. I've done several assignments during my studies, however, I only had this passive learning experience and wasn't actively searching and learning the things I really wanted to learn. I hope this opportunity will make me a better programmer than before.      Among countless trending repositories on Github, I picked a repo called "learn-python"(  https
Read more

[W4] Lab 3

Image
For Lab 3, I made some changes for my CLI tool, detectURL. 1. I made my program to exit with the right exit code (0, 1, or 3) 2 I made my program to support 3 flags, --all, --bad, and --good. I first created  Issue #5  and Issue #6  as the Lab's requirement. Then I created a new branches from master by using the command: git checkout -b issue-5 I made the changes which are: b5224c  and 9869105 I merged each of the commit to the master branch and pushed the master branch to GitHub. Now it supports 3 new flags and if you check the exit code after execution, it will have different exit codes for different scenarios.
Read more